Skip to content

Update(useNavigationState): removed eslint + deps array from useEffect #8076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Monsef-Noubadji wants to merge 2 commits into from
Closed

Update(useNavigationState): removed eslint + deps array from useEffect #8076

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3317d5
Update(useNavigationState): removed eslint + deps array from useEffect
Monsef-Noubadji Aug 14, 2025
3242493
Update apps/site/hooks/react-client/useNavigationState.ts
Monsef-Noubadji Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/site/hooks/react-client/useNavigationState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
return () => element.removeEventListener('scroll', handleScroll);
}
// We need this effect to run only on mount
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

Check warning on line 37 in apps/site/hooks/react-client/useNavigationState.ts

View workflow job for this annotation

GitHub Actions / Quality checks 

React Hook useEffect has missing dependencies: 'handleScroll', 'id', 'navigationState', and 'ref'. Either include them or remove the dependency array
};

export default useNavigationState;
Loading