-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: Remove unnecessary margin from sidebar item #8084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a visual issue by removing unnecessary margin from sidebar items that was causing "loose pixels" to appear between sidebar items.
- Removes the
mb-pxTailwind CSS class from sidebar items to eliminate spacing gaps - Addresses a UI consistency issue where unwanted pixel spacing was visible between navigation items
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mikeesto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a suggestion... if we add a gap of 1px to:
nodejs.org/packages/ui-components/src/Containers/Sidebar/SidebarGroup/index.module.css
Line 29 in 8ab9cea
| .itemList { |
|
Am I the only one that feels they're too close together now? |
|
Lighthouse Results
|
bump @adi-ray |
@ovflowd thanks for the note! Were you referring to the normal or the progression sidebars? |
All good! We can merge as is :) |
Description
Eliminated the "loose pixel" which was being shown between sidebar items.
Validation
Before:


After:
Related Issues
Fixes #8082
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.