-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(redirects): don't prefix /docs
#8095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a redirect rule by removing the /en/ language prefix from the documentation redirect destination. The change corrects the redirect from /documentation/:path* to point to /docs/:path* instead of /en/docs/:path*.
- Removes unnecessary language prefix from documentation redirect destination
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8095 +/- ##
==========================================
+ Coverage 73.12% 73.17% +0.04%
==========================================
Files 97 97
Lines 8440 8440
Branches 229 228 -1
==========================================
+ Hits 6172 6176 +4
+ Misses 2267 2263 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
bjohansebas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this was introduced with #5615 - along with all of the other /en/* paths immediately around this change.
probably easy to have copy-pasta'ed
|
Requesting fast track |
|
Lighthouse Results
|
| { | ||
| "source": "/documentation/:path*", | ||
| "destination": "/en/docs/:path*" | ||
| "destination": "/docs/:path*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually was an intentional design choice. In the past the website had /docs pages. But now these same pages are on learn, hence we have also redirects from some of these docs to /learn.
|
@nodejs/nodejs-website I'm reverting this PR. |
I doubt this was an intentional design choice