Skip to content

Conversation

@avivkeller
Copy link
Member

I doubt this was an intentional design choice

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings August 20, 2025 21:33
@avivkeller avivkeller requested a review from a team as a code owner August 20, 2025 21:33
@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Aug 20, 2025 9:36pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a redirect rule by removing the /en/ language prefix from the documentation redirect destination. The change corrects the redirect from /documentation/:path* to point to /docs/:path* instead of /en/docs/:path*.

  • Removes unnecessary language prefix from documentation redirect destination

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Aviv Keller <me@aviv.sh>
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.17%. Comparing base (660f38f) to head (35415f7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8095      +/-   ##
==========================================
+ Coverage   73.12%   73.17%   +0.04%     
==========================================
  Files          97       97              
  Lines        8440     8440              
  Branches      229      228       -1     
==========================================
+ Hits         6172     6176       +4     
+ Misses       2267     2263       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this was introduced with #5615 - along with all of the other /en/* paths immediately around this change.

probably easy to have copy-pasta'ed

@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Aug 20, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 20, 2025
@avivkeller
Copy link
Member Author

Requesting fast track

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 74 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 96 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Aug 20, 2025
Merged via the queue into main with commit 2ff9d3e Aug 20, 2025
19 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the en/docs-fix branch August 20, 2025 22:52
{
"source": "/documentation/:path*",
"destination": "/en/docs/:path*"
"destination": "/docs/:path*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually was an intentional design choice. In the past the website had /docs pages. But now these same pages are on learn, hence we have also redirects from some of these docs to /learn.

@ovflowd
Copy link
Member

ovflowd commented Aug 20, 2025

@nodejs/nodejs-website I'm reverting this PR.

ovflowd added a commit that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants