Skip to content

Conversation

@avivkeller
Copy link
Member

Ref: https://github.com/nodejs/nodejs.org/actions/runs/17165842812/job/48706001475#step:9:151 - This must be explicitly set for provenance, apparently

Copilot AI review requested due to automatic review settings August 22, 2025 21:08
@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Aug 22, 2025
@avivkeller avivkeller requested a review from a team as a code owner August 22, 2025 21:08
@vercel
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Aug 22, 2025 9:15pm

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explicit repository URLs to package.json files across multiple packages to resolve a provenance requirement issue in GitHub Actions workflows.

  • Adds repository.url field to four package.json files
  • Ensures proper provenance metadata for package publishing
  • Fixes GitHub Actions workflow failure related to missing repository information

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
packages/ui-components/package.json Added repository URL field for provenance compliance
packages/remark-lint/package.json Added repository URL field for provenance compliance
packages/rehype-shiki/package.json Added repository URL field for provenance compliance
packages/i18n/package.json Added repository URL field for provenance compliance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@avivkeller
Copy link
Member Author

Requesting fast-track and enabling auto-merge.

fyi @nodejs/web-infra (since this modifies package.json files)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 97 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 91 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.84%. Comparing base (ef86853) to head (1cb7e4a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8104      +/-   ##
==========================================
- Coverage   75.88%   75.84%   -0.05%     
==========================================
  Files         112      112              
  Lines        9433     9433              
  Branches      303      304       +1     
==========================================
- Hits         7158     7154       -4     
- Misses       2274     2278       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

avivkeller and others added 3 commits August 22, 2025 17:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Aviv Keller <me@aviv.sh>
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avivkeller
Copy link
Member Author

avivkeller commented Aug 22, 2025

Per https://docs.npmjs.com/generating-provenance-statements#prerequisites

  • Review the Linux Foundation Immutable Record notice, which applies to the public transparency log.

  • Install the latest version of the npm CLI (ensure you are on 9.5.0+ as older versions don't support npm provenance). For more information, see "Try the latest stable version of npm."

  • Ensure your package.json is configured with a public repository that matches (case-sensitive) where you are publishing with provenance from.

  • Set up automation with a supported CI/CD provider to publish your packages to the npm registry.

@avivkeller avivkeller added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit a9e90a2 Aug 22, 2025
19 checks passed
@avivkeller avivkeller deleted the fix/id-token branch August 22, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants