-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(id-token): explicitly set repository.url #8104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds explicit repository URLs to package.json files across multiple packages to resolve a provenance requirement issue in GitHub Actions workflows.
- Adds repository.url field to four package.json files
- Ensures proper provenance metadata for package publishing
- Fixes GitHub Actions workflow failure related to missing repository information
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/ui-components/package.json | Added repository URL field for provenance compliance |
| packages/remark-lint/package.json | Added repository URL field for provenance compliance |
| packages/rehype-shiki/package.json | Added repository URL field for provenance compliance |
| packages/i18n/package.json | Added repository URL field for provenance compliance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Requesting fast-track and enabling auto-merge. fyi @nodejs/web-infra (since this modifies |
|
Lighthouse Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8104 +/- ##
==========================================
- Coverage 75.88% 75.84% -0.05%
==========================================
Files 112 112
Lines 9433 9433
Branches 303 304 +1
==========================================
- Hits 7158 7154 -4
- Misses 2274 2278 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aviv Keller <me@aviv.sh>
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also set repository.directory? https://docs.npmjs.com/cli/v11/configuring-npm/package-json#repository
|
Per https://docs.npmjs.com/generating-provenance-statements#prerequisites
|
Ref: https://github.com/nodejs/nodejs.org/actions/runs/17165842812/job/48706001475#step:9:151 - This must be explicitly set for provenance, apparently