-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(nvm): duplicated code #8153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes duplicated code from the nvm installation script by eliminating redundant verification commands. The change streamlines the script by keeping only the essential installation step.
- Removes duplicate Node.js version verification commands
- Simplifies the nvm installation snippet to focus on core installation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8153 +/- ##
=======================================
Coverage 76.59% 76.59%
=======================================
Files 115 115
Lines 9602 9602
Branches 322 322
=======================================
Hits 7355 7355
Misses 2246 2246
Partials 1 1 ☔ View full report in Codecov by Sentry. |
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speedy
|
Marking this as fast-track, given it is a fix for a noticeable/noticed issue on a highly visible page |
Ref https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1756941182705769