-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(cleanup): move mdx files out of root #8167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorganizes the MDX-related files by moving them from the root of apps/site into a dedicated mdx/ subdirectory and relocating utility functions to the util/ directory for better code organization.
- Moves MDX compiler, components, and plugins into
mdx/subdirectory - Relocates JavaScript evaluator utility to
util/directory - Updates import paths throughout the codebase to reflect new file locations
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/site/util/evaluator.ts | New utility file containing the JavaScript evaluator functionality |
| apps/site/next.dynamic.mjs | Updates imports to use new MDX file locations |
| apps/site/mdx/plugins.mjs | Moved and renamed plugin exports from root directory |
| apps/site/mdx/components.mjs | Moved MDX components configuration to mdx subdirectory |
| apps/site/mdx/compiler.mjs | Moved MDX compiler with updated import paths |
| apps/site/components/Downloads/Release/ReleaseCodeBox.tsx | Updates import to use new evaluator location |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8167 +/- ##
==========================================
- Coverage 76.59% 76.58% -0.02%
==========================================
Files 115 115
Lines 9602 9602
Branches 322 322
==========================================
- Hits 7355 7354 -1
- Misses 2246 2247 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
araujogui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to not have everything on root !
9504d4d to
01018b1
Compare
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
|
Lighthouse Results
|
These files don't all need to be in the root of
apps/site. This cleans that up by putting these into anmdx/subdir (and moving the compiler toutils)