Skip to content

Conversation

@avivkeller
Copy link
Member

These files don't all need to be in the root of apps/site. This cleans that up by putting these into an mdx/ subdir (and moving the compiler to utils)

Copilot AI review requested due to automatic review settings September 12, 2025 22:36
@avivkeller avivkeller requested review from a team as code owners September 12, 2025 22:36
@vercel
Copy link

vercel bot commented Sep 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Sep 15, 2025 9:26pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the MDX-related files by moving them from the root of apps/site into a dedicated mdx/ subdirectory and relocating utility functions to the util/ directory for better code organization.

  • Moves MDX compiler, components, and plugins into mdx/ subdirectory
  • Relocates JavaScript evaluator utility to util/ directory
  • Updates import paths throughout the codebase to reflect new file locations

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/site/util/evaluator.ts New utility file containing the JavaScript evaluator functionality
apps/site/next.dynamic.mjs Updates imports to use new MDX file locations
apps/site/mdx/plugins.mjs Moved and renamed plugin exports from root directory
apps/site/mdx/components.mjs Moved MDX components configuration to mdx subdirectory
apps/site/mdx/compiler.mjs Moved MDX compiler with updated import paths
apps/site/components/Downloads/Release/ReleaseCodeBox.tsx Updates import to use new evaluator location

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.58%. Comparing base (746c040) to head (48484a6).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8167      +/-   ##
==========================================
- Coverage   76.59%   76.58%   -0.02%     
==========================================
  Files         115      115              
  Lines        9602     9602              
  Branches      322      322              
==========================================
- Hits         7355     7354       -1     
- Misses       2246     2247       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to not have everything on root !

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 92 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 94 🟢 100 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@avivkeller avivkeller added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit cf23e7c Sep 15, 2025
16 checks passed
@avivkeller avivkeller deleted the move-mdx-files-out-of-root branch September 15, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants