Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings October 21, 2025 01:19
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner October 21, 2025 01:19
@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 21, 2025 1:20am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the initial release selection logic in the download section by defaulting to 'Current' for all cases, removing the conditional check based on the pathname.

Key changes:

  • Removed pathname-based conditional logic for determining the initial release
  • Set 'Current' as the default initial release for all pages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

const initialRelease = pathname.endsWith('/current')
? 'Current'
: 'Active LTS';
const initialRelease = 'Current';
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pathname variable is now unused after removing the conditional logic. Consider removing it from the component's dependencies or props if it's no longer needed elsewhere in the component.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Oct 21, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
226 1 225 0
View the full list of 1 ❄️ flaky test(s)
test::getAPIDocs

Flake rate in main: 100.00% (Passed 0 times, Failed 1 times)

Stack Traces | 0.00449s run time
[Error [ERR_TEST_FAILURE]: Cannot destructure property 'versionWithPrefix' of 'releaseData.find(...)' as it is undefined.] {
  code: 'ERR_TEST_FAILURE',
  failureType: 'testCodeFailure',
  cause: TypeError [Error]: Cannot destructure property 'versionWithPrefix' of 'releaseData.find(...)' as it is undefined.
      at getAPIDocs (file:.../runner/work/nodejs.org/nodejs..../scripts/orama-search/get-documents.mjs:21:11)
      at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async TestContext.<anonymous> (.../runner/work/nodejs.org/nodejs..../orama-search/__tests__/get-documents.test.mjs:26:18)
      at async Test.run (node:internal/test_runner/test:980:9)
      at async startSubtestAfterBootstrap (node:internal/test_runner/harness:296:3)
}

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@AugustinMauroy AugustinMauroy deleted the current-hotfix branch October 30, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants