Skip to content

Conversation

@MattIPv4
Copy link
Member

Description

https://github.com/nodejs/nodejs.org/actions/runs/18669937464/job/53228682825

Validation

Admin merge this PR.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@MattIPv4 MattIPv4 requested a review from a team as a code owner October 21, 2025 01:39
Copilot AI review requested due to automatic review settings October 21, 2025 01:39
@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 21, 2025 1:40am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Slack webhook configuration to the notify-on-push GitHub Action to enable notifications when code is pushed to the repository. The change addresses a workflow failure where the webhook parameter was missing.

Key Changes:

  • Added webhook parameter to the notify-on-push action, passing it from GitHub secrets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MattIPv4 MattIPv4 changed the title Pass webhook through to notify-on-push action fix(ci): pass webhook through to notify-on-push action Oct 21, 2025
@MattIPv4 MattIPv4 merged commit 9ca2c45 into main Oct 21, 2025
12 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/notify-push-webhook branch October 21, 2025 01:41
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.36%. Comparing base (6af8e13) to head (ba0a893).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8252      +/-   ##
==========================================
- Coverage   76.40%   76.36%   -0.05%     
==========================================
  Files         115      115              
  Lines        9647     9647              
  Branches      317      318       +1     
==========================================
- Hits         7371     7367       -4     
- Misses       2274     2278       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants