fix: run-id reference in bundle-compare workflow #8365
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the bundle-compare workflow where the incorrect GitHub Actions context property was used to reference a workflow run. The change corrects workflow_run.workflow_id to workflow_run.id for the run-id parameter.
- Corrects the
run-idparameter to use the workflow run identifier instead of the workflow template identifier
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8365 +/- ##
==========================================
- Coverage 76.29% 76.26% -0.03%
==========================================
Files 118 118
Lines 9903 9903
Branches 336 336
==========================================
- Hits 7555 7553 -2
- Misses 2346 2348 +2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aviv Keller <me@aviv.sh>
MattIPv4
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow_idrefers to the workflow,idrefers to the run