-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(context): supply PR to bundle-compare
#8369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the bundle comparison workflow by explicitly passing the PR number to the actions-comment-pull-request action. The workflow is triggered by workflow_run events, where the PR context isn't automatically available, so this change ensures the comment is posted to the correct pull request.
- Adds the
pr-numberparameter to the PR comment action, extracting it from the workflow_run event payload
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8369 +/- ##
==========================================
+ Coverage 76.24% 76.29% +0.04%
==========================================
Files 118 118
Lines 9903 9903
Branches 337 336 -1
==========================================
+ Hits 7551 7555 +4
+ Misses 2350 2346 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
a parting thought: if it doesnt read or know the PR, how does it comment on it in other workflows? |
it depends on the workflow trigger. It reads it for |
Apparently this action does not read the PR from the context of a workflow run event correctly.