Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Nov 24, 2025

Apparently this action does not read the PR from the context of a workflow run event correctly.

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings November 24, 2025 16:44
@avivkeller avivkeller requested a review from a team as a code owner November 24, 2025 16:44
@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 24, 2025 4:46pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the bundle comparison workflow by explicitly passing the PR number to the actions-comment-pull-request action. The workflow is triggered by workflow_run events, where the PR context isn't automatically available, so this change ensures the comment is posted to the correct pull request.

  • Adds the pr-number parameter to the PR comment action, extracting it from the workflow_run event payload

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.29%. Comparing base (76ac237) to head (0557cc7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8369      +/-   ##
==========================================
+ Coverage   76.24%   76.29%   +0.04%     
==========================================
  Files         118      118              
  Lines        9903     9903              
  Branches      337      336       -1     
==========================================
+ Hits         7551     7555       +4     
+ Misses       2350     2346       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Nov 24, 2025
@bmuenzenmeyer
Copy link
Contributor

a parting thought: if it doesnt read or know the PR, how does it comment on it in other workflows?

Merged via the queue into main with commit 5649cfa Nov 24, 2025
22 checks passed
@avivkeller avivkeller deleted the fast-track-hot-fix branch November 24, 2025 17:09
@avivkeller
Copy link
Member Author

a parting thought: if it doesnt read or know the PR, how does it comment on it in other workflows?

it depends on the workflow trigger. It reads it for pull_request[_target], but apparently not for workflow_run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants