Skip to content

Conversation

@canerakdas
Copy link
Member

Description

I didn’t get a chance to review #8443 in time, and when I checked it, I couldn’t exit the dialog once it was opened. With this PR, I added a simple close icon. Also, Safari tends to zoom in on inputs with font sizes below 16px, so I set the input font size to 16px for mobile resolutions

Validation

Before

image

After

image

@canerakdas canerakdas requested a review from a team as a code owner December 24, 2025 20:44
Copilot AI review requested due to automatic review settings December 24, 2025 20:44
@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Dec 24, 2025 8:51pm

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@canerakdas
Copy link
Member Author

@nodejs/nodejs-website can we fast track this as a hotfix?

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.59%. Comparing base (3b7e8e7) to head (ce8de89).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8446      +/-   ##
==========================================
- Coverage   73.64%   73.59%   -0.05%     
==========================================
  Files         108      108              
  Lines        9193     9193              
  Branches      312      313       +1     
==========================================
- Hits         6770     6766       -4     
- Misses       2421     2425       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical usability issue where the mobile search dialog couldn't be closed once opened, and addresses Safari's auto-zoom behavior on small input fields.

  • Added a close button to the search modal for mobile users
  • Increased input font size to 16px on mobile to prevent Safari from zooming in on focus
  • Applied consistent dark mode styling to the new close button

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/ui-components/src/Common/Search/Modal/index.tsx Added Modal.Close component with custom styling class
packages/ui-components/src/Common/Search/Modal/index.module.css Added styling for the close button with absolute positioning and dark mode support
packages/ui-components/src/Common/Search/Input/index.module.css Changed input font size from text-sm to text-base on mobile, text-sm on md+ breakpoints to prevent Safari auto-zoom

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller enabled auto-merge December 24, 2025 20:54
@avivkeller
Copy link
Member

Whoops!

@avivkeller avivkeller added this pull request to the merge queue Dec 24, 2025
Merged via the queue into nodejs:main with commit 5a52702 Dec 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants