Skip to content

Conversation

@avivkeller
Copy link
Member

Closes: #555
Fixes: #533


Hides the navItems if no navItems are provided.

Copilot AI review requested due to automatic review settings December 29, 2025 16:07
@avivkeller avivkeller requested a review from a team as a code owner December 29, 2025 16:07
@vercel
Copy link

vercel bot commented Dec 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Dec 29, 2025 4:08pm

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Dec 29, 2025
@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 90 🟠 88 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 93 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 99 🟢 96 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.73%. Comparing base (732de04) to head (000db26).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8467      +/-   ##
==========================================
+ Coverage   73.69%   73.73%   +0.04%     
==========================================
  Files         108      108              
  Lines        9210     9210              
  Branches      313      312       -1     
==========================================
+ Hits         6787     6791       +4     
+ Misses       2421     2417       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the navItems prop optional in the NavBar component to support cases where no navigation items need to be displayed. This fixes issues #555 and #533.

Key Changes:

  • Made navItems prop optional in the NavBar component type definition
  • Added conditional rendering to hide the nav items container when navItems is not provided
  • Created a new Storybook story (NoNavItems) to demonstrate the component without navigation items

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/ui-components/src/Containers/NavBar/index.tsx Made navItems prop optional and added conditional rendering; also improved classNames usage by removing array wrapper
packages/ui-components/src/Containers/NavBar/index.stories.tsx Refactored common story props and added NoNavItems story to test component without nav items
packages/ui-components/package.json Bumped package version from 1.4.3 to 1.4.4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.72 MB
New Total Size 3.72 MB
Delta -87.00 B (-0.00%)

Changes

➕ Added Assets (4)
Name Size
.next/static/chunks/93a1a14fca310be3.js 205.09 KB
.next/static/chunks/9808cd623048ec3a.js 420.20 KB
.next/static/chunks/42c9abc63853de02.js 420.20 KB
.next/static/chunks/d4eb2e6b148840cb.js 420.20 KB
➖ Removed Assets (4)
Name Size
.next/static/chunks/af43b109609dbef9.js 205.09 KB
.next/static/chunks/1bcb423cc68e4519.js 420.23 KB
.next/static/chunks/cdc0187de4bc1dc9.js 420.23 KB
.next/static/chunks/4e8127ac24711e68.js 420.23 KB

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Dec 29, 2025
@ovflowd
Copy link
Member

ovflowd commented Dec 29, 2025

@nodejs/nodejs-website fast-tracking as bug fix.

@ovflowd ovflowd added this pull request to the merge queue Dec 29, 2025
Merged via the queue into main with commit 587fe94 Dec 29, 2025
32 checks passed
@ovflowd ovflowd deleted the navbar/hide-if-no-nav-items branch December 29, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants