meta: deduplicate dependencies #8499
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8499 +/- ##
==========================================
+ Coverage 73.73% 73.77% +0.04%
==========================================
Files 108 108
Lines 9210 9210
Branches 312 312
==========================================
+ Hits 6791 6795 +4
+ Misses 2417 2413 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (9)
➖ Removed Assets (9)
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
👀 @avivkeller, ideally, I'd prefer this to be merged before any of the open Dependabot PRs, just so that I don't need to essentially recreate this and have folks review the diff again? |
|
(My SGTM is just a sign-off, I haven't tested the PR yet) |
|
LGTM, but can we wait until after the Dependabot PRs land, since it's possible they will re-introduce some duplicated dependencies? |
|
Oh true, sure, I can recreate this once they're landed then. Don't worry about reviewing this until after this is recreated then, as I imagine the diff will change. |
Description
Generated by
pnpm dedupeat the root.Changed dependencies: https://github.com/nodejs/nodejs.org/actions/runs/20609289576/job/59190909986?pr=8499#step:3:15
Validation
All the lockfile changes here should be very carefully reviewed, and the functionality of the site should be thoroughly tested, given the number of dependencies that've changed (though of course all within semver compliance).
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.