feat: adds asdf installation instructions to downloads page #8533
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
This PR adds support for asdf, a cross-platform version manager, to the Node.js downloads page. It includes installation instructions, UI components, and configuration files to help contributors and users install Node.js using asdf.
Changes:
- Added ASDF icon component and integrated it into the installation methods
- Added English localization string describing asdf as a cross-platform version manager
- Added asdf to the installation methods configuration with macOS and Linux compatibility
- Created installation script with step-by-step asdf setup instructions
- Added .tool-versions file for asdf users to easily configure the repository's Node.js and pnpm versions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/Icons/InstallationMethod/index.ts | Exports the new ASDF icon component |
| packages/ui-components/src/Icons/InstallationMethod/ASDF.tsx | New SVG icon component for asdf with purple branding |
| packages/i18n/src/locales/en.json | Adds description of asdf as a cross-platform version manager |
| apps/site/util/download/constants.json | Registers asdf as an installation method for macOS and Linux |
| apps/site/snippets/en/download/asdf.bash | Provides installation instructions for asdf with Homebrew and ZSH |
| .tool-versions | Specifies Node.js 24.12.0 and pnpm 10.24.0 for asdf users |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,5 @@ | |||
| import { | |||
There was a problem hiding this comment.
Let's make our site work without needing an icon. Let me know if you'd like me to push a commit achieving that, if you need help.
There was a problem hiding this comment.
Thanks. I got that working, but wondering if we should make the text left aligned always? What's your preference?
Without the icon / special alignment/padding changes:
There was a problem hiding this comment.
the latter looks much better to me
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8533 +/- ##
==========================================
+ Coverage 74.97% 75.04% +0.06%
==========================================
Files 103 103
Lines 9036 9047 +11
Branches 312 312
==========================================
+ Hits 6775 6789 +14
+ Misses 2259 2255 -4
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. |
3 participants
Description
Adds instructions to install, configure, and set up using Node.js via
asdf, the multi-platform version manager that supports multiple languages, runtimes, and package managers. Additionally, this PR adds a.tool-versionsfile so contributors usingasdfcan easily get started with the repo with the proper and specific Node.js and pnpm versions.Validation
Related Issues
Implements the changes approved in #8488.
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.