Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
@skyeyeye you've opened SEVERAL pull requests. Please stop, each one alerts our team. Please do any and all changes in this PR, and only this PR. Subsequently superfluous changes will be considered spam. |
|
I’m unable to access the Vercel preview logs due to permission restrictions. The project builds successfully locally (pnpm build). Could you please share the specific failure reason? |
|
You need to rebase. Your base branch is significantly out of date. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8649 +/- ##
==========================================
- Coverage 75.13% 75.06% -0.07%
==========================================
Files 104 104
Lines 9098 9093 -5
Branches 314 315 +1
==========================================
- Hits 6836 6826 -10
- Misses 2260 2265 +5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
877d71c to
a1b53e2
Compare
|
@skyeyeye please lint and format |
avivkeller
left a comment
There was a problem hiding this comment.
Looks like a lot of things got messed up. You should just have to revert your last commit and run pnpm format
fbfb49d to
e5f8a33
Compare
MattIPv4
left a comment
There was a problem hiding this comment.
Putting a block on this, not for an issue with the change itself, but because we need to make sure messaging goes out on the account before we land this and call the issue closed.
Description
Closes #7873
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.