Skip to content

Conversation

@GoldFish2500
Copy link
Contributor

The function uvwasi__malloc may return a null pointer. We must check uv_connect_sock before using it further.

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another instance of this for uv_tcp_init.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@GoldFish2500 I assume this is needed in addition to the 2 other PRs you had submitted? If so could you rebase so we get a test run?

@aduh95 aduh95 merged commit 94a9f59 into nodejs:main Aug 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants