Skip to content

Conversation

@lum1n0us
Copy link
Contributor

@lum1n0us lum1n0us commented May 19, 2025

  • add test-symlink-outbox

fix #299

@lum1n0us
Copy link
Contributor Author

@ospencer Hi, sorry to bother you. I'm not sure if you are able to approve and/or merge this PR, but you are my only contact related to uvwasi. I hope you can help review this PR and possibly approve and merge it. Thanks a lot.

@cjihrig
Copy link
Collaborator

cjihrig commented May 29, 2025

@lum1n0us the CI is failing.

@lum1n0us lum1n0us force-pushed the fix/about_symlink branch from e18da63 to 1b2ab00 Compare May 29, 2025 01:45
@lum1n0us
Copy link
Contributor Author

I've fixed the unused variables errors in uvwasi CI / ubuntu-latest - debug-log. The other two seem related to infrastructure.

From Build Fuzzers(address). https://github.com/nodejs/uvwasi/actions/runs/15101901324/job/43082367465?pr=303

#9 243.0 E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/f/file/libmagic-mgc_5.38-4_amd64.deb  Connection failed [IP: 185.125.190.83 80]
#9 243.0 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
#9 243.0 Fetched 1304 kB in 1min 58s (11.0 kB/s)
#9 ERROR: process "/bin/sh -c apt-get update && apt-get install -y make autoconf automake libtool" did not complete successfully: exit code: 100
------
 > [2/6] RUN apt-get update && apt-get install -y make autoconf automake libtool:
------
process "/bin/sh -c apt-get update && apt-get install -y make autoconf automake libtool" did not complete successfully: exit code: 100
2025-05-29 00:25:51,[239](https://github.com/nodejs/uvwasi/actions/runs/15101901324/job/43082367465?pr=303#step:4:240) - helper - ERROR - Docker build failed.
2025-05-29 00:25:51,239 - root - ERROR - Failed to build external project.
2025-05-29 00:25:51,239 - root - ERROR - Error building fuzzers for (commit: 323b7a2b34f0f2a2e21aa684c94dd272885dca95, pr_ref: refs/pull/303/merge).

AND. From Test Coverage. https://github.com/nodejs/uvwasi/actions/runs/15101901326/job/43082367566?pr=303

Finished .info-file creation
genhtml: WARNING: Use of uninitialized value in subroutine entry
genhtml: ERROR: unable to open /cmd_line: Permission denied

BTW, Is there a way I can re-run the CI or trigger it without bothering you?

@cjihrig cjihrig merged commit 98da5ad into nodejs:main May 29, 2025
7 of 8 checks passed
@cjihrig
Copy link
Collaborator

cjihrig commented May 29, 2025

Is there a way I can re-run the CI or trigger it without bothering you?

It might work on future PRs now that you're no longer a first time contributor.

@aduh95 aduh95 mentioned this pull request Aug 16, 2025
aduh95 added a commit that referenced this pull request Sep 2, 2025
Notable changes:

- Disallow malformed path with null byte (#266) (7aaa0b4)
- Preserve trailing slash in file path (#268) (afffaaa)
- Disallow absolute path at the raw WASI level (#270) (9811374)
- Error if creating symlink to absolute path (#272) (c8d4f01)
- Add cflite and document normalize path (#280) (6eeddba)
- Resolve old_path in uvwasi_path_symlink() (#303) (98da5ad)
- Use index rather than `telldir`/`seekdir` to represent `fd_readdir` cookie (#298) (392e1f1)
- fix: static library name (#305) (146e516)
- fix: do not put header files in a subfolders (#302) (ec28b58)
- fix: explicitly export symbols (#308) (4e9b4e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uvwasi_path_symlink does not check old_path like others

2 participants