Skip to content

Conversation

@avivkeller
Copy link
Member

Copilot AI review requested due to automatic review settings December 25, 2025 20:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the security configuration of the OpenSSF Scorecard workflow by moving permissions from the job level to the top level and replacing the broad read-all permission with specific, granular permissions required for the workflow to function.

Key Changes:

  • Moved permissions from job-level to workflow-level in scorecard.yml
  • Replaced permissions: read-all with specific permissions (security-events: write, id-token: write, contents: read, actions: read)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ovflowd ovflowd added this pull request to the merge queue Dec 25, 2025
Merged via the queue into nodejs:main with commit 9f3c83a Dec 25, 2025
10 checks passed
@ovflowd
Copy link
Member

ovflowd commented Dec 25, 2025

I've fast-tracked this PR due to it causing a security workflow to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scorecard workflow's permissions: read-all forces callers to grant unnecessary permissions Workflows: Scorecard Failure / Compare Builds Failure

5 participants