Skip to content

Updated workflows for sm1.12 checking. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blueblur0730 wants to merge 1 commit into from
Closed

Updated workflows for sm1.12 checking. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-on-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ jobs:
sm_branch: "1.11-dev"
spcomp_version: "1.11.x"

- sm_version: "1.12"
Copy link
Owner

@nosoop nosoop Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, so 1.11 is now considered oldstable — I don't think there's any compelling reason to keep 1.11 now, and the release steps weren't built with multiple SM versions in mind (there's only release archives for Linux and Windows, both containing 32-bit and 64-bit extension builds).

This PR may be effectively redundant with #22, but we'll see once that gets a final once-over and merged.

sm_branch: "1.12-dev"
spcomp_version: "1.12.x"
Copy link
Owner

@nosoop nosoop Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly spcomp 1.12 has flawed codegen due to the major refactoring work done on sourcepawn's side, so I'd probably opt to keep this at 1.11.x.
SourceMod plugin files are generally architecture-independent and there currently aren't any changes in plugin-space that improve support of 64-bit memory.

Copy link
Contributor Author

@blueblur0730 blueblur0730 Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sm1.12-7170 seems to resolved some flawed codegen problem I remembered, which is the version I have been using until now.
As for the improvement of memory functionality you are right, nothing bright so it is a reason to stay 1.11.x. If this is not necessary then I agree that this pr can be closed.


- os: ubuntu-20.04
os_short: linux
package_ext: tar.gz
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pull-request-ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ jobs:
sm_branch: "1.11-dev"
spcomp_version: "1.11.x"

- sm_version: "1.12"
Copy link
Owner

@nosoop nosoop Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think sm_version is a key / value that's used anywhere in the workflow. I think you wanted a corresponding meta_branch?

sm_branch: "1.12-dev"
spcomp_version: "1.12.x"

- os: ubuntu-20.04
os_short: linux

Expand Down