fix dexie cache filter #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by correcting the event format passed to nostr-tool's matchFilter the dexie cache adaptor applies some simple filtering for efficiency reasons before using nostr-tool's matchFilter to apply the full NIP-01 ruleset basic root cause analysis: it is likely that nostr-tools changed the event format expected by matchFilter and this was missed during a dependancy upgrade for a number of reasons: 1. the use of `as any` remove type checking 2. nostr-tools doesn't use semantic versioning to highlight breaking changes 3. a cursory test using simple filters would have returned correct results
Collaborator
|
I'm not sure I understand the issue here? Is the cache adapter not returning the right results? Or returning no results? |
Contributor
Author
|
in some cases the cache adatper returns too many results it does this because it fails to call nostr-tool's matchFilter function correctly. |
Collaborator
|
Gotcha, thanks. I'll respond on the other thread now. |
Collaborator
|
hey @DanConwayDev -- finally had a chance to dig into this -- I think this PR is incorrect, the I added a test to check and it seems the filter is being matched properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by correcting the event format passed to nostr-tool's matchFilter
the dexie cache adaptor applies some simple filtering for efficiency reasons before using nostr-tool's matchFilter to apply the full NIP-01 ruleset
basic root cause analysis:
it is likely that nostr-tools changed the event format expected by matchFilter and this was missed during a dependancy upgrade for a number of reasons:
as anyremove type checking