Skip to content

Add inbound profile signature verification #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alltheseas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add inbound profile signature verification #360

alltheseas wants to merge 2 commits into from

Conversation

@alltheseas
Copy link
Contributor

@alltheseas alltheseas commented Dec 2, 2025

problem

ndk does not validate inbound profile/kind0 events

suggested solution

  • Always treat kind‑0 events as must‑verify: bypass sampling/trust and enforce synchronous signature checks so invalid profiles are dropped immediately.
    • Reuse verifyAndReport for both relay/no‑relay paths; add early returns to keep control flow simple.
    • Preserve existing behavior for other kinds (sampling + optional async verification).

context

discovered lack of profile validation via yakihonne-web: nostrability/nostrability#262 (comment)
closes #359

@alltheseas
Always verify profile metadata signatures
7fc022b 
Closes: nostr-dev-kit#359

Signed-off-by: alltheseas <64376233+alltheseas@users.noreply.github.com>
@alltheseas
Refine profile verification flow
512a9ed 
Signed-off-by: alltheseas <64376233+alltheseas@users.noreply.github.com>
@alltheseas alltheseas mentioned this pull request Dec 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add signature validation for inbound profile/kind0 events

1 participant

@alltheseas