Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went down a rabbit hole in NDK 3.x with a bug around fetching user profile data (and zap methods). See #363
To reproduce i decided to improve the user tests and create a case that failed/showed the problem.
This PR has:
EventGeneratorrefactor: Replace any with NDKEventGeneratorrefactor: Some helper methods, better types for pubkeyNDK Usertests: Make time deterministic (using Vitest fake timers https://vitest.dev/config/faketimers)NDK Usertests: Don't use deprecated fields/methods likegetUserandimagefieldNDK Usertests: Truely test race criteria for old/new profile updatesNDK Usertests: Add a test to prove RetrievinggetZapMethodstwice returns empty map (ndk 3.0-beta) #363The last item i think proves the bug