Skip to content

fix(i18n): force install command direction to 'ltr' #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 6, 2026
+3 −3
Merged

fix(i18n): force install command direction to 'ltr' #1055

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6706126
fix(i18n): force install command direction to `'ltr'`
BobbieGoede Feb 5, 2026
523a56a
fix(i18n): set text direction to 'auto'
BobbieGoede Feb 5, 2026
6342bc3
fix(i18n): set install command direction to 'ltr'
BobbieGoede Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/components/Terminal/Install.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const copyCreateCommand = () => copyCreate(getFullCreateCommand())
<span class="w-2.5 h-2.5 rounded-full bg-fg-subtle" />
<span class="w-2.5 h-2.5 rounded-full bg-fg-subtle" />
</div>
<div class="px-3 pt-2 pb-3 sm:px-4 sm:pt-3 sm:pb-4 space-y-1 overflow-x-auto">
<div class="px-3 pt-2 pb-3 sm:px-4 sm:pt-3 sm:pb-4 space-y-1 overflow-x-auto" dir="ltr">
Copy link
Contributor

@serhalp serhalp Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and other others) might easily get mistakenly "fixed" in the future. Could we leave an explanatory comment on each one? or maybe a custom directive with an expressive name that just sets dir="ltr" could serve the same purpose? https://vuejs.org/guide/reusability/custom-directives

Copy link
Contributor

@skaldebane skaldebane Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like v-always-ltr?

<!-- Install command - render all PM variants, CSS controls visibility -->
<div
v-for="pm in packageManagers"
Expand Down Expand Up @@ -162,7 +162,7 @@ const copyCreateCommand = () => copyCreate(getFullCreateCommand())
<!-- Run command (only if package has executables) - render all PM variants -->
<template v-if="executableInfo?.hasExecutable">
<!-- Comment line -->
<div class="flex items-center gap-2 pt-1">
<div class="flex items-center gap-2 pt-1" dir="auto">
<span class="text-fg-subtle font-mono text-sm select-none"
># {{ $t('package.run.locally') }}</span
>
Expand Down Expand Up @@ -196,7 +196,7 @@ const copyCreateCommand = () => copyCreate(getFullCreateCommand())
<!-- Create command (for packages with associated create-* package) - render all PM variants -->
<template v-if="createPackageInfo">
<!-- Comment line -->
<div class="flex items-center gap-2 pt-1 select-none">
<div class="flex items-center gap-2 pt-1 select-none" dir="auto">
<span class="text-fg-subtle font-mono text-sm"># {{ $t('package.create.title') }}</span>
<TooltipApp
:text="$t('package.create.view', { packageName: createPackageInfo.packageName })"
Expand Down
Loading