-
-
Notifications
You must be signed in to change notification settings - Fork 218
test: add tests for error-handler #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { createError } from 'h3' | ||
| import * as v from 'valibot' | ||
| import { handleApiError } from '../../../../server/utils/error-handler' | ||
|
|
||
| describe('handleApiError', () => { | ||
| const fallback = { message: 'Something went wrong', statusCode: 500 } | ||
|
|
||
| it('re-throws H3 errors as-is', () => { | ||
| const h3Err = createError({ statusCode: 404, message: 'Not found' }) | ||
|
|
||
| expect(() => handleApiError(h3Err, fallback)).toThrow(h3Err) | ||
| }) | ||
|
|
||
| it('throws a 404 with the first issue message for valibot errors', () => { | ||
| const schema = v.object({ name: v.pipe(v.string(), v.minLength(1, 'Name is required')) }) | ||
|
|
||
| let valibotError: unknown | ||
| try { | ||
| v.parse(schema, { name: '' }) | ||
| } catch (e) { | ||
| valibotError = e | ||
| } | ||
|
Comment on lines
+18
to
+23
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I really wanted to use safe parse and construct the v.ValiError yourself but it somehow feels like more work 🫠 |
||
|
|
||
| expect(() => handleApiError(valibotError, fallback)).toThrow( | ||
| expect.objectContaining({ statusCode: 404, message: 'Name is required' }), | ||
| ) | ||
| }) | ||
|
|
||
| it('throws a fallback error with the given statusCode and message', () => { | ||
| expect(() => | ||
| handleApiError(new Error('unexpected'), { message: 'Bad gateway', statusCode: 502 }), | ||
| ).toThrow(expect.objectContaining({ statusCode: 502, message: 'Bad gateway' })) | ||
| }) | ||
|
|
||
| it('defaults fallback statusCode to 502 when not provided', () => { | ||
| expect(() => handleApiError('some string error', { message: 'Upstream failed' })).toThrow( | ||
| expect.objectContaining({ statusCode: 502, message: 'Upstream failed' }), | ||
| ) | ||
| }) | ||
|
|
||
| it('uses the custom fallback statusCode when provided', () => { | ||
| expect(() => handleApiError(null, { message: 'Service unavailable', statusCode: 503 })).toThrow( | ||
| expect.objectContaining({ statusCode: 503, message: 'Service unavailable' }), | ||
| ) | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a transitive dependency but we need it as a direct devDependency for sake of resolving types in tests