-
-
Notifications
You must be signed in to change notification settings - Fork 219
feat: add a copy readme as markdown button on pages/package #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carwack
wants to merge
9
commits into
npmx-dev:main
Choose a base branch
from
carwack:feat/add-pages-package-readme-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
602e69e
feat: add copy readme button for package page with html
carwack 7e816a6
feat: add i18n en translation
carwack 41fe20a
feat: also pass the original content as md when fetching readmeData
carwack 3301de8
feat: ensure reactivity and clean up of tooltip
carwack 1d8d4f4
feat: add some more translations
carwack 617efb8
fix: capitalize Markdown in EN translations
carwack 93bcbfa
refactor: remove duplicate classes on the copy Markdown button
carwack bc86318
test: add tests for readme Markdown content extraction
carwack f06e31b
refactor: remove the trim() from readmeData md
carwack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,9 +67,15 @@ const { data: readmeData } = useLazyFetch<ReadmeResponse>( | |
| const version = requestedVersion.value | ||
| return version ? `${base}/v/${version}` : base | ||
| }, | ||
| { default: () => ({ html: '', playgroundLinks: [], toc: [] }) }, | ||
| { default: () => ({ html: '', md: '', playgroundLinks: [], toc: [] }) }, | ||
| ) | ||
|
|
||
| //copy README file as Markdown | ||
| const { copied: copiedReadme, copy: copyReadme } = useClipboard({ | ||
| source: () => readmeData.value?.md ?? '', | ||
| copiedDuring: 2000, | ||
| }) | ||
|
|
||
| // Track active TOC item based on scroll position | ||
| const tocItems = computed(() => readmeData.value?.toc ?? []) | ||
| const { activeId: activeTocId, scrollToHeading } = useActiveTocItem(tocItems) | ||
|
|
@@ -1130,12 +1136,39 @@ onKeyStroke( | |
| </a> | ||
| </h2> | ||
| <ClientOnly> | ||
| <ReadmeTocDropdown | ||
| v-if="readmeData?.toc && readmeData.toc.length > 1" | ||
| :toc="readmeData.toc" | ||
| :active-id="activeTocId" | ||
| :scroll-to-heading="scrollToHeading" | ||
| /> | ||
| <div class="flex items-center gap-2"> | ||
| <!-- Copy readme as Markdown button --> | ||
| <TooltipApp | ||
| v-if="readmeData?.md" | ||
| :text="$t('package.readme.copy_as_markdown')" | ||
| position="bottom" | ||
| > | ||
| <button | ||
| type="button" | ||
| @click="copyReadme()" | ||
| class="px-2 py-1.5 font-mono text-xs rounded transition-colors duration-150 inline-flex items-center gap-1.5" | ||
| :class=" | ||
| copiedReadme ? 'text-accent bg-accent/10' : 'text-fg-subtle bg-bg hover:text-fg' | ||
| " | ||
| :aria-label=" | ||
| copiedReadme ? $t('common.copied') : $t('package.readme.copy_as_markdown') | ||
| " | ||
| > | ||
| <span | ||
| :class="copiedReadme ? 'i-carbon:checkmark' : 'i-simple-icons:markdown'" | ||
| class="size-3" | ||
| aria-hidden="true" | ||
| /> | ||
| {{ copiedReadme ? $t('common.copied') : $t('common.copy') }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this "copy" text looks nicer title case (i.e. |
||
| </button> | ||
carwack marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </TooltipApp> | ||
| <ReadmeTocDropdown | ||
| v-if="readmeData?.toc && readmeData.toc.length > 1" | ||
| :toc="readmeData.toc" | ||
| :active-id="activeTocId" | ||
| :scroll-to-heading="scrollToHeading" | ||
| /> | ||
| </div> | ||
| </ClientOnly> | ||
| </div> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.