Skip to content

style: improve border visibility in select package section#1064

Open
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:style/improve-border-in-select-package-section
Open

style: improve border visibility in select package section#1064
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:style/improve-border-in-select-package-section

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 6, 2026

I think the border in select package section is less visible in both dark and light mode. We can slightly improve it.

Before: The border used --border which is very faint (oklch 0.269 in dark mode, 0.8514 in light mode)

After: The border now uses --border-hover which is more visible (oklch 0.371 in dark mode, 0.715 in light mode)

before:
border-two

after:
border-one

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 1:53am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 1:53am
npmx-lunaria Ignored Ignored Feb 6, 2026 1:53am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The change modifies the styling in the compare page's Empty state section by updating a CSS class. Specifically, the border colour class is changed from border-border to border-border-hover. This is a single line modification with no impact to the component's logic, data handling, or control flow. No public or exported declarations are affected by this change.

Suggested reviewers

  • danielroe
  • 43081j
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining a specific styling improvement to border visibility in the select package section with technical details and visual comparisons.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant