Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
📝 WalkthroughWalkthroughThe PR adds a new totalLikes metric to package comparisons. The composable app/composables/usePackageComparison.ts now fetches likes from /api/social/likes/{name}, exposes an optional totalLikes field on PackageComparisonData, and includes totalLikes in facet computations. Comparison facet types and FACET_INFO gain a totalLikes entry. Translation keys for the new facet (label and description) are added across English (en.json, en-GB.json, en-US.json) and French (fr-FR.json) locale files, and test fixture mappings are updated. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/composables/usePackageComparison.ts (1)
109-120: Consider surfacing likes fetch failures as “unknown” rather than “0”.A failed likes request currently renders as 0 likes, which can be misleading. Aligning with downloads (null/undefined on failure) keeps comparisons honest.
♻️ Suggested adjustment
export interface PackageComparisonData { package: ComparisonPackage downloads?: number /** Total likes from atproto */ - totalLikes: number + totalLikes?: number /** Package's own unpacked size (from dist.unpackedSize) */ packageSize?: number @@ - $fetch<PackageLikes>(`/api/social/likes/${name}`).catch(() => ({ - totalLikes: 0, - userHasLiked: false, - })), + $fetch<PackageLikes>(`/api/social/likes/${name}`).catch(() => null), @@ - totalLikes: likes.totalLikes, + totalLikes: likes?.totalLikes,Also applies to: 168-168
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Following this msg on discord :

This PR add like as a metric (I don't really know if it's a relevant metric)