Skip to content

fix: lazy loading packages#966

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
Flo0806:fix/lazy-search
Feb 5, 2026
Merged

fix: lazy loading packages#966
danielroe merged 2 commits intonpmx-dev:mainfrom
Flo0806:fix/lazy-search

Conversation

@Flo0806
Copy link
Collaborator

@Flo0806 Flo0806 commented Feb 4, 2026

fixes: #658


The await has block the page. Now we use it without async and handle it inside a watch

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 0:26am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 0:26am
npmx-lunaria Ignored Ignored Feb 5, 2026 0:26am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The org page component is modified to use lazy fetching instead of awaiting the API call synchronously. The 404 error handling is relocated from the direct API call to a reactive watcher that monitors the response status and error properties. This approach maintains the same error messaging whilst allowing the page to render without blocking on the initial API response. Package computation and counting logic remain unmodified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset: removing a blocking await and implementing non-blocking async handling via a watch.
Linked Issues check ✅ Passed The code changes address issue #658 by removing the blocking await that prevented UI interactions during search, replacing it with non-blocking reactive handling.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the blocking behaviour in the org packages page and are directly related to resolving issue #658.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit 37a1469 Feb 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to click on packages when searching

3 participants