Skip to content

Don't show same info twice when 0 dependencies#976

Open
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:no-deps-no-duplicate
Open

Don't show same info twice when 0 dependencies#976
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:no-deps-no-duplicate

Conversation

@gameroman
Copy link
Contributor

@gameroman gameroman commented Feb 5, 2026

Before

image

After

image

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 0:41am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 0:41am
npmx-lunaria Ignored Ignored Feb 5, 2026 0:41am

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[...package].vue 0.00% 10 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

Changes have been made to the package page Vue component to conditionally render dependency and install-size separators. The forward slash separators previously displayed between direct and total dependency counts are now shown only when at least one dependency is present. The same conditional rendering logic has been applied to the install-size separator. The underlying logic for displaying total dependency counts, loading states, and placeholder elements remains unchanged and is now wrapped within the added conditional blocks.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description includes visual examples (before/after images) that clearly demonstrate the issue and the fix being applied to dependency display logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant