Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
2ae0b82 to
52cada0
Compare
📝 WalkthroughWalkthroughA new documentation page was added at docs/content/2.guide/4.vscode-extension.md describing the npmx VS Code extension. It documents installation (Marketplace/Open VSX or 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/content/2.guide/4.vscode-extension.md (1)
32-32: Consider using British English phrasing.In British English, "have a look" is more commonly used than "take a look". As per coding guidelines, the review language is set to en-GB.
✍️ Suggested British English phrasing
-For full configuration options and detailed usage, take a look at the <a href="https://github.com/npmx-dev/vscode-npmx#readme" target="_blank" rel="noopener noreferrer">GitHub repository</a>. +For full configuration options and detailed usage, have a look at the <a href="https://github.com/npmx-dev/vscode-npmx#readme" target="_blank" rel="noopener noreferrer">GitHub repository</a>.
|
|
||
| ## Configuration | ||
|
|
||
| For full configuration options and detailed usage, take a look at the <a href="https://github.com/npmx-dev/vscode-npmx#readme" target="_blank" rel="noopener noreferrer">GitHub repository</a>. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
curl -s -o /dev/null -w "%{http_code}" "https://github.com/npmx-dev/vscode-npmx"Repository: npmx-dev/npmx.dev
Length of output: 64
Update language to British English.
Change "take a look" to "have a look" to align with en-GB conventions.
For full configuration options and detailed usage, have a look at the <a href="https://github.com/npmx-dev/vscode-npmx#readme" target="_blank" rel="noopener noreferrer">GitHub repository</a>.
🧰 Tools
🪛 LanguageTool
[locale-violation] ~32-~32: In British English, “have a look” is more commonly used.
Context: ...nfiguration options and detailed usage, take a look at the <a href="https://github.com/npmx...
(TAKE_A_LOOK)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
To get the word out about the vs-code extension, the npmx docs should have a section about them. Eventually the extension docs should probably live in the npmx docs entirely, although right now I think its better to keep the repo as the source of truth to avoid PR spam here while the extension evolves.
Also, we've gotten a request to support the extension in Cursor: npmx-dev/vscode-npmx#26. Cursor requires a link to the extension on an official project page, otherwise it won't be reviewed and made available in extension search.
Screenshots