Skip to content

fix: hide likes when data is being fetched #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sacrosanctic wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −13
Open

fix: hide likes when data is being fetched #984

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d618297
.
sacrosanctic Feb 5, 2026
d44bae6
.
sacrosanctic Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions app/pages/package/[...package].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,10 +399,13 @@ const { user } = useAtproto()

const authModal = useModal('auth-modal')

const { data: likesData } = useFetch(() => `/api/social/likes/${packageName.value}`, {
default: () => ({ totalLikes: 0, userHasLiked: false }),
server: false,
})
const { data: likesData, status: likesStatus } = useFetch(
() => `/api/social/likes/${packageName.value}`,
{
default: () => ({ totalLikes: 0, userHasLiked: false }),
server: false,
},
)

const isLikeActionPending = ref(false)

Expand All @@ -414,12 +417,12 @@ const likeAction = async () => {

if (isLikeActionPending.value) return

const currentlyLiked = likesData.value?.userHasLiked ?? false
const currentLikes = likesData.value?.totalLikes ?? 0
const currentlyLiked = likesData.value.userHasLiked
const currentLikes = likesData.value.totalLikes

// Optimistic update
likesData.value = {
totalLikes: currentlyLiked ? currentLikes - 1 : currentLikes + 1,
totalLikes: currentLikes + (currentlyLiked ? -1 : 1),
userHasLiked: !currentlyLiked,
}

Expand Down Expand Up @@ -606,32 +609,32 @@ onKeyStroke(
<!-- Package likes -->
<TooltipApp
:text="
likesData?.userHasLiked ? $t('package.likes.unlike') : $t('package.likes.like')
likesData.userHasLiked ? $t('package.likes.unlike') : $t('package.likes.like')
"
position="bottom"
>
<button
@click="likeAction"
type="button"
:title="
likesData?.userHasLiked ? $t('package.likes.unlike') : $t('package.likes.like')
likesData.userHasLiked ? $t('package.likes.unlike') : $t('package.likes.like')
"
class="inline-flex items-center gap-1.5 font-mono text-sm text-fg hover:text-fg-muted transition-colors duration-200"
:aria-label="
likesData?.userHasLiked ? $t('package.likes.unlike') : $t('package.likes.like')
likesData.userHasLiked ? $t('package.likes.unlike') : $t('package.likes.like')
"
>
<span
:class="
likesData?.userHasLiked
likesData.userHasLiked
? 'i-lucide-heart-minus text-red-500'
: 'i-lucide-heart-plus'
"
class="w-4 h-4"
aria-hidden="true"
/>
<span>{{
formatCompactNumber(likesData?.totalLikes ?? 0, { decimals: 1 })
<span v-if="likesStatus !== 'pending'">{{
formatCompactNumber(likesData.totalLikes, { decimals: 1 })
}}</span>
</button>
</TooltipApp>
Expand Down
Loading