Skip to content

fix: add nocorrect to atproto auth#987

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
sacrosanctic:comparative-anglerfish
Feb 5, 2026
Merged

fix: add nocorrect to atproto auth#987
danielroe merged 1 commit intonpmx-dev:mainfrom
sacrosanctic:comparative-anglerfish

Conversation

@sacrosanctic
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 3:55am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 3:55am
npmx-lunaria Ignored Ignored Feb 5, 2026 3:55am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The authentication modal component was refactored to consolidate input attribute configuration. Three separate input attributes—autocomplete="off" and spellcheck="false"—were replaced with a single v-bind="noCorrect" directive on the login handle input field. This approach uses a bound object to manage correctness-related input behaviour instead of explicit attribute declarations. No structural changes or modifications to control flow were introduced.

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided by the author, making it impossible to assess the intent or context of the changes. Add a clear pull request description explaining the purpose of adding nocorrect to the auth input and why this change improves the user experience.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
app/components/Header/AuthModal.client.vue (1)

56-63: ⚠️ Potential issue | 🟠 Major

Define or import noCorrect before binding it.

v-bind="noCorrect" references an identifier that doesn’t exist in the script block, which will break the template. Please add a local const or import the object.

🔧 Proposed fix
<script setup lang="ts">
 import { useAtproto } from '~/composables/atproto/useAtproto'
 import { authRedirect } from '~/utils/atproto/helpers'

 const handleInput = shallowRef('')

+const noCorrect = {
+  autocomplete: 'off',
+  autocorrect: 'off',
+  autocapitalize: 'off',
+  spellcheck: 'false',
+} as const
+
 const { user, logout } = useAtproto()

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit 6f5d8b6 Feb 5, 2026
16 checks passed
@sacrosanctic sacrosanctic deleted the comparative-anglerfish branch February 5, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants