feat: add trail effect on sparkline pulse#991
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe PR modifies sparkline pulse settings in Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@graphieros Although this is not directly related to this PR, I think we also should provide an option to disable animation from accessibility perspective (some may found it difficult to focus on the main content when there's moving object on the page). Does vue-data-ui already have a functionality to do this such as detecting ref. Understanding Success Criterion 2.2.2: Pause, Stop, Hide | WAI | W3C - https://www.w3.org/WAI/WCAG21/Understanding/pause-stop-hide.html |
Yes, the pulse does not show when prefers-reduced-motion, it is imposed by the library |
|
I added a comment in the config to make that information available :) |
|
Great, thank you! 🙂 |
|
keeping it open for now, I noticed I left a dreaded log in my last vue-data-ui build (shaaame) 😭 |
The effect can be tempered or disabled in
WeeklyDownloadStats.vueatconfig.style.line.pulse.trail:I think it looks cool ^^