Skip to content

feat: add trail effect on sparkline pulse#991

Merged
danielroe merged 4 commits intonpmx-dev:mainfrom
graphieros:main
Feb 5, 2026
Merged

feat: add trail effect on sparkline pulse#991
danielroe merged 4 commits intonpmx-dev:mainfrom
graphieros:main

Conversation

@graphieros
Copy link
Contributor

@graphieros graphieros commented Feb 5, 2026

  • bump vue-data-ui to 3.14.6
  • enable the trail effect in the sparkline chart config
Before After
BEFORE (1) AFTER (1)

The effect can be tempered or disabled in WeeklyDownloadStats.vue at config.style.line.pulse.trail:

trail: {
  show: true, // set to false to revert to previous behavior
  length: 20,
  opacity: 0.75, // can be reduced to temper the effect (ej. 0.5)
}

I think it looks cool ^^

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Error Error Feb 5, 2026 7:03am
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 7:03am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 5, 2026 7:03am

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The PR modifies sparkline pulse settings in app/components/Package/WeeklyDownloadStats.vue: radius changed from 2 to 1.5, trail.length changed from 6 to 20, and trail.opacity added with value 0.75; pulse.show remains true. The package.json dependency vue-data-ui is bumped from 3.14.5 to 3.14.7. No public interfaces, exported entities, method additions, or signature changes were made.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is directly related to the changeset, describing both the vue-data-ui version bump and the trail effect configuration in WeeklyDownloadStats.vue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shuuji3
Copy link
Member

shuuji3 commented Feb 5, 2026

@graphieros Although this is not directly related to this PR, I think we also should provide an option to disable animation from accessibility perspective (some may found it difficult to focus on the main content when there's moving object on the page).

Does vue-data-ui already have a functionality to do this such as detecting prefers-reduced-motion? But probably it's better have npmx setting item since prefers-reduced-motion requires to configure browser or OS setting.

ref. Understanding Success Criterion 2.2.2: Pause, Stop, Hide | WAI | W3C - https://www.w3.org/WAI/WCAG21/Understanding/pause-stop-hide.html

@graphieros
Copy link
Contributor Author

@graphieros Although this is not directly related to this PR, I think we also should provide an option to disable animation from accessibility perspective (some may found it difficult to focus on the main content when there's moving object on the page).

Does vue-data-ui already have a functionality to do this such as detecting prefers-reduced-motion? But probably it's better have npmx setting item since prefers-reduced-motion requires to configure browser or OS setting.

ref. Understanding Success Criterion 2.2.2: Pause, Stop, Hide | WAI | W3C - https://www.w3.org/WAI/WCAG21/Understanding/pause-stop-hide.html

Yes, the pulse does not show when prefers-reduced-motion, it is imposed by the library

@graphieros
Copy link
Contributor Author

graphieros commented Feb 5, 2026

I added a comment in the config to make that information available :)

@shuuji3
Copy link
Member

shuuji3 commented Feb 5, 2026

Great, thank you! 🙂

@graphieros graphieros marked this pull request as draft February 5, 2026 06:55
@graphieros
Copy link
Contributor Author

graphieros commented Feb 5, 2026

keeping it open for now, I noticed I left a dreaded log in my last vue-data-ui build (shaaame) 😭
More coffee please!

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit c12afc2 Feb 5, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants