Epic: viem + TacoClient + fix ES import issue #710
+4,377
−602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Added eslint disable comments for necessary any types in dynamic viem type declarations - Fixed import order in examples and tests - Added file-level eslint disables for complex wrapper implementations - Resolved all lint errors while maintaining functionality
- Fixed eslint disable comment placement for any type assertions - Ensured all CI/CD lint checks pass successfully
(to prevent making unnecessary network calls)
Co-authored-by: Manuel Montenegro <manuel@nucypher.com>
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
…o all package.json files to expose TypeScript declarations
…import This is because import from 'ethers/lib/utils' causes compatibility issues with projects that uses ES Modules.
… failure case for unsupported networks
Muhammad-Altabba
changed the title
Muhammad-Altabba
requested review from
cygnusv,
derekpierre,
manumonti and
theref
theref
approved these changes
Oct 16, 2025
- Moving signer from constructor to encrypt methods - Simplifying some configs at tests
manumonti
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Just a collection of features implemented in other PRs created while working on Fileverse agents.
Issues fixed/closed:
The PRs do the following:
Why it's needed:
Improve usability, support a wider tech stack (with supporting viem) and fix usage issue from ES module projects.
Notes for reviewers:
All included sub PRs have been already reviewed. This branch is protected no direct push has been made except it was rebased once.