feat(conditions): add :nullAddress as automatically injected context variable #738
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable This context variable is automatically injected on the node side and resolves to the Ethereum null address (0x0000000000000000000000000000000000000000). - Add :nullAddress to AUTOMATICALLY_INJECTED_CONTEXT_PARAMS - Add :nullAddress to RESERVED_CONTEXT_PARAMS to prevent manual setting - Existing tests already handle automatically injected parameters Related to nucypher/nucypher#3668
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## signing-epic #738 +/- ##
===============================================
Coverage ? 89.74%
===============================================
Files ? 97
Lines ? 8445
Branches ? 291
===============================================
Hits ? 7579
Misses ? 863
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
:nullAddressas an automatically injected context variable that resolves to the Ethereum null address (0x0000000000000000000000000000000000000000) on the node side.Motivation
This is the taco-web companion PR to nucypher/nucypher#3668, which adds the
:nullAddressprotected context variable to the nucypher node implementation.Changes
:nullAddressto AUTOMATICALLY_INJECTED_CONTEXT_PARAMS array:nullAddressto RESERVED_CONTEXT_PARAMS array to prevent manual setting by usersTesting
The existing test suite already handles automatically injected parameters:
Related PRs