[Feature] Storage Rework #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start Rework - Reworked Storages to be available to any addon with little work. Storages store many BlockPos so that they can be referenced later - Added interfaces for Storages (IStorage, IServerStorage (no sync), ISyncServerStorage, and IClientStorage) - Added base PMWStorage class - Completely rewrote PMWStorages - Added StorageInstance to hold storage IDs, maps, and storage factories - Added S2CStoragePacket for syncing storage data - Added PMWUtils#isCornerAdjacent, #testAround, #storageCornerAdjacent, and #isRadarCornerAdjacent - Moved PMWNetworking#RADARS_ID to RadarStorage.ID - Deprecated PMWSavedData, replaced by PMWStorageSavedData - Moved ExampleOverlay to the example mod id - ID Overlay now requires you to crouch and renders all overlays - Changed NearbyRadarsCommand to StoragesCommand and added new features. This change remaps /nearbyradars <x> to /storages pmweatherapi:radars <x> Took 1 minute
Push command updates - Changed NearbyRadarsCommand to StoragesCommand and added new features. This change remaps /nearbyradars <x> to /storages pmweatherapi:radars <x> Took 1 minute
# Conflicts: # gradle.properties # src/main/java/net/nullved/pmweatherapi/client/render/IDOverlay.java Took 7 minutes
Took 1 minute
# Conflicts: # gradle.properties Took 3 minutes
- Add Client Storages Took 1 hour 5 minutes
- Storages should be complete or near complete - Storages allow you to save data in a format of your choice so that the data can be read even when chunks are not loaded. Useful for things such as showing radar positions in unloaded chunks (Radar Networks coming soon!) - Added storages for Metars (Weather Stations) and WSR-88Ds - Added #renderTexture methods to Radar Overlays - Added RadarMode#disableBaseRendering to disable the defualt pixel renderer (Needed by Hezi for Radar Overhaul) - And a bunch more stuff that I don't to write right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks storages to be able to be used by addon developers instead of internally. Wiki article coming soon