Skip to content

Conversation

@ben-vargas
Copy link
Contributor

@ben-vargas ben-vargas commented Dec 12, 2025

Summary

Adds support for reasoning_effort: "none" for GPT-5.2 and GPT-5.1 general purpose models, which disables the reasoning phase entirely for faster responses when reasoning is not needed.

Motivation

Per OpenAI API documentation and the Codex CLI implementation:

  • GPT-5.1 defaults to none and supports: none, low, medium, high
  • GPT-5.2 (being newer than 5.1) also supports none along with low, medium, high, xhigh

References:

  • OpenAI API docs - reasoning_effort: "gpt-5.1 defaults to none, which does not perform reasoning. The supported reasoning values for gpt-5.1 are none, low, medium, and high."
  • Codex CLI ReasoningEffort enum includes None variant (codex-rs/protocol/src/openai_models.rs)
  • Codex CLI request builder passes ReasoningEffort::None through to API without rejection (codex-rs/core/src/client.rs)
  • Codex CLI config docs list model_reasoning_effort = "none" as valid (docs/config.md)

Changes

Added

  • gpt-5.2-none and gpt-5.1-none model mappings in model-map.ts
  • supportsNone detection in getReasoningConfig() for GPT-5.1/5.2 general purpose models
  • 4 new unit tests for "none" reasoning behavior (197 total tests)

Changed

  • Models that don't support "none" auto-convert to appropriate fallback:
    • Codex / Codex Max → "low"
    • Codex Mini → "medium" (unchanged from before)
  • Documentation updated with complete reasoning effort support matrix per model family

Testing

npm run typecheck  # ✅ Pass
npm test           # ✅ 197 tests passing
npm run build      # ✅ Pass

Manually tested with openai/gpt-5.2-none model - confirmed working.

Reasoning Effort Support Matrix

Model none low medium high xhigh
GPT-5.2
GPT-5.1
GPT-5.1-Codex ❌→low
GPT-5.1-Codex-Max ❌→low
GPT-5.1-Codex-Mini ❌→medium ❌→medium ❌→high

Notes

  • This plugin defaults to "medium" for better coding assistance; users must explicitly configure "none" if desired
  • The OpenAI API docs state GPT-5.1 defaults to "none", but we intentionally keep "medium" as our default since this is a coding assistant plugin

…T-5.1

Add support for `reasoning_effort: "none"` which disables the reasoning
phase entirely, resulting in faster responses when reasoning is not needed.

Changes:
- Add `gpt-5.2-none` and `gpt-5.1-none` model mappings
- Update getReasoningConfig() to allow "none" for GPT-5.1/5.2 general purpose
- Codex variants auto-convert "none" to "low" (or "medium" for Mini)
- Add 4 new unit tests (197 total)
- Update documentation with reasoning effort support matrix

References:
- OpenAI API docs: "gpt-5.1 defaults to none, supports: none, low, medium, high"
- Codex CLI: ReasoningEffort enum includes None variant
- Codex CLI: docs/config.md lists "none" as valid config option
numman-ali pushed a commit that referenced this pull request Dec 17, 2025
…fix, and HTML version update

This release combines fixes and features from PRs #62, #63, and #64:

### Added
- "none" reasoning effort support for GPT-5.2 and GPT-5.1 general purpose models
- gpt-5.2-none and gpt-5.1-none model mappings and presets (now 18 total models)
- 4 new unit tests for "none" reasoning behavior (197 total tests)

### Fixed
- Orphaned function_call_output 400 API errors - now converts orphans to assistant
  messages to preserve context while avoiding API errors
- OAuth HTML version display updated from 1.0.4 to 4.1.0

### Technical Details
- getReasoningConfig() detects GPT-5.1 general purpose models and allows "none"
- Codex variants auto-convert "none" to "low" (or "medium" for Codex Mini)
- Orphan handling now works regardless of tools presence in request

Contributors: @code-yeongyu (PR #63), @kanemontreuil (PR #64), @ben-vargas (PR #62)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
numman-ali added a commit that referenced this pull request Dec 17, 2025
@ben-vargas ben-vargas closed this Dec 17, 2025
@ben-vargas ben-vargas deleted the fix-gpt-5-2-none-reasoning branch December 17, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant