fix(modules): prevent ISR from caching 404 error responses #2149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2148, #2140
Problem
The
/modulespage intermittently returns 404 errors when accessed directly. The issue occurs because:queryCollection('landing').path('/modules')transiently fails, a 404 is thrownSolution
Set
Cache-ControlandCDN-Cache-Controlheaders tono-storebefore throwing the 404 error, preventing ISR from caching the error response.