Preserve data when regenerating json files from addon-datastore #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This approach doesn't look right. Other data is what is being deleted, not just translations. The commit generated from testing still looks broken: nvdaes/addon-datastore@2b688a1. Please confirm testing before marking as ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
### Description
In PR nvaccess/addon-datastore#7368, a bug was introduced where security data was removed from json files
### Development approach
With assistance of Copilot, seems that when deleting translations the dictionary is mutated so that then some data is not added in the transformation.
So, instead of deleting translations directly, data is copied to a different dictionary and then added to json files as appropriate.
### Testing performed
Currently tests are been performed at
https://github.com/nvdaes/addon-datastore/actions/runs/21413861127
### Note
@seanbudd, if it's posible that I cannot way tonight until tests are finished. Please feel free to see results and proceed to merge if appropriate.