Fix which-key delay settings #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iton0
reviewed
Dec 20, 2024
|
|
||
| -- Decrease mapped sequence wait time | ||
| -- Displays which-key popup sooner | ||
| vim.opt.timeoutlen = 300 |
Contributor
There was a problem hiding this comment.
Keep this in. Removing this increases the timeoutlen to the default 1000 ms for all other map sequences.
iton0
reviewed
Dec 20, 2024
| 'folke/which-key.nvim', | ||
| event = 'VimEnter', -- Sets the loading event to 'VimEnter' | ||
| opts = { | ||
| delay = 0, |
Contributor
There was a problem hiding this comment.
Add a comment here explaining delay option and that it is independent of the timeoutlen option.
jensenr30
force-pushed
the
fix-which-key-delay
branch
from
fb4e3d0 to
a827c80
Compare
The which-key plugin used to rely on vim.opt.timeoutlen, but it was updated a few months ago to use its own opt.delay instead. https://github.com/folke/which-key.nvim/blob/8ab96b38a2530eacba5be717f52e04601eb59326/NEWS.md?plain=1#L10 I set which-key's delay to 0 ms because it makes it feel snappy and responsive! That way, we give new users a good first impression.
jensenr30
force-pushed
the
fix-which-key-delay
branch
from
a827c80 to
70b0566
Compare
Collaborator
|
Hey @iton0 thank you SO MUCH for helping polish this change and for all your contributions in general. @jensenr30 thanks for this fix! Much appreciated. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to make which-key pop up instantly. I tried changing
vim.opt.timeoutlento 0, then to 1000, but it made no difference. While searching through thewhich-keyrepository, I discovered they changed how the plugin's delay is configured. They used to rely onvim.opt.timeoutlen, but they changed that a few months ago. Now they use their ownopt.delayinstead.The previous 300 ms delay led me assume there was some horribly inefficient code somewhere in neovim, lua, or which-key. I changed the delay to 0 ms and that makes
which-keyfeel really snappy and responsive! I think other newcomers to neovim would appreciate that feel.