Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix Lua language server configuration by changing references from lua_ls to lua-language-server across comments, Mason installation configuration, and LSP setup calls.
Changes:
- Updated documentation comment to reference
lua-language-serverinstead oflua_ls - Changed Mason ensure_installed entry from
lua_lstolua-language-server - Modified vim.lsp.config() and vim.lsp.enable() calls to use
lua-language-serverinstead oflua_ls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| local ensure_installed = vim.tbl_keys(servers or {}) | ||
| vim.list_extend(ensure_installed, { | ||
| 'lua_ls', -- Lua Language server | ||
| 'lua-language-server', -- Lua Language server |
There was a problem hiding this comment.
Potential naming inconsistency: Using 'lua-language-server' (Mason package name) instead of 'lua_ls' (LSP server name). While 'lua-language-server' is correct for Mason's ensure_installed list, the vim.lsp.config() and vim.lsp.enable() calls below (lines 631 and 655) may require the LSP server name 'lua_ls' instead, similar to how other servers in the commented examples above use server names like 'gopls', 'rust_analyzer', and 'ts_ls' (lines 597-605). Please verify that both the Mason package name AND the LSP server name are correctly specified in their respective contexts.
|
|
||
| -- Special Lua Config, as recommended by neovim help docs | ||
| vim.lsp.config('lua_ls', { | ||
| vim.lsp.config('lua-language-server', { |
There was a problem hiding this comment.
Potential incorrect server name: 'lua-language-server' appears to be the Mason package name rather than the LSP server name. With nvim-lspconfig loaded (line 478), vim.lsp.config() typically expects server names like 'lua_ls' (the nvim-lspconfig server name), not Mason package names. The commented server examples above (lines 596-605) use server names like 'gopls', 'rust_analyzer', 'ts_ls' - all following the nvim-lspconfig naming convention with underscores. Please verify whether 'lua-language-server' or 'lua_ls' is the correct server name for vim.lsp.config() in this context.
| vim.lsp.config('lua-language-server', { | |
| vim.lsp.config('lua_ls', { |
| }, | ||
| }) | ||
| vim.lsp.enable 'lua_ls' | ||
| vim.lsp.enable 'lua-language-server' |
There was a problem hiding this comment.
Potential incorrect server name: 'lua-language-server' appears to be the Mason package name rather than the LSP server name. With nvim-lspconfig loaded (line 478), vim.lsp.enable() typically expects server names like 'lua_ls' (the nvim-lspconfig server name), not Mason package names. The loop above (lines 624-628) passes server names from the servers table to vim.lsp.enable(), and those examples use names like 'gopls', 'rust_analyzer', 'ts_ls'. Please verify whether 'lua-language-server' or 'lua_ls' is the correct server name for vim.lsp.enable() in this context.
NOTE
Please verify that the
base repositoryabove has the intended destination!Github by default opens Pull Requests against the parent of a forked repository.
If this is your personal fork and you didn't intend to open a PR for contribution
to the original project then adjust the
base repositoryaccordingly.