fix(ALL): improve vim.str_utfindex and vim.str_byteindex usage
#2199
+98
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLeoP
commented
Dec 29, 2025
| end | ||
|
|
||
| -- TODO: Remove after compatibility with Neovim=0.10 is dropped | ||
| H.str_byteindex = vim.fn.has('nvim-0.11') == 1 and function(s, i) return vim.str_byteindex(s, 'utf-32', i) end |
Member
Author
There was a problem hiding this comment.
I had my doubts about whether or not H.str_byteindex should only be defined conditionally inside of the below check for vim.fn.has('nvim-0.10') == 0 as it is the only usage of vim.str_byteindex in this module. But, in the end decided against it because it seemed cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1901
This includes a small shim (in each of the affected modules) that uses the new signature on Neovim >= 0.11. Let me know if a different approach would be preferred.