-
Notifications
You must be signed in to change notification settings - Fork 290
feat(clue): allow mode arrays for clues and triggers #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clue): allow mode arrays for clues and triggers #2202
Conversation
|
Thanks for the PR! The code looks reasonable. Would you mind also updating the |
2170461 to
18348ff
Compare
ccf041c to
a57a0ad
Compare
echasnovski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of commented nit picks, this looks very clean. Thanks for the attention to details in docs!
Could you also add a 'CHANGELOG.md' entry? Don't forget to mention yourself and this PR similarly to how it was done in the past.
6ab6307 to
675e3a9
Compare
Resolve nvim-mini#2192 Co-authored-by: Evgeni Chasnovski <evgeni.chasnovski@gmail.com>
675e3a9 to
4246b54
Compare
echasnovski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
There are very minor nit picks that I'll address in a separate branch.
Allow arrays to be used to define the modes for clues and triggers.
For example, these two configurations are equivalent: