feat(core): support org-enforce-todo-dependencies by PannenetsF · Pull Request #741 · nvim-orgmode/orgmode

PannenetsF · 2024-06-02T10:15:21Z

Hi guys, I just impl the option for org-enforce-todo-dependencies, which will prevent parent TODOs from toggling when it has some unfinished children.

I am not sure if you are still interested in it, as the related issue #274 was updated 2 years ago.

Here comes the reference.
https://orgmode.org/manual/TODO-dependencies.html

:)

seflue · 2024-06-02T21:29:04Z

Hi guys, I just impl the option for org-enforce-todo-dependencies, which will prevent parent TODOs from toggling when it has some unfinished children.

I am not sure if you are still interested in it, as the related issue #274 was updated 2 years ago.

Many thanks for the contribution. 👍 Old issues don't mean, there is no interest in a working implementation. It just means, that we need more active contributors. 😄

From a very quick overlook your code looks good - I will try it out as soon as I can.

Here comes the reference. https://orgmode.org/manual/TODO-dependencies.html

:)

I wasn't even aware of this, but Orgmode is soo big ... you always learn something new ... 😅

add warning for blocked tasks

PannenetsF · 2024-06-03T05:29:03Z

Haha, glad to hear that!

I am migrating my org from emacs to nvim, and will try to implement some daily functions into nvim-orgmode.

Dardanos-Aeolus · 2024-09-30T12:06:25Z

Hi there,

I really dont want to be pushy.
I would love this PR to be accepted because it would be a good Feature.

Thanks for your great work here.

seflue · 2024-10-19T13:12:08Z

@PannenetsF I finally found the time to play around with your contribution. First I was not sure if I misunderstood how the feature is supposed to work, but what was immediately noticeable is that changing the TODO state of a parent headline is completely blocked. And it is actually blocked on pressing "t", so if I want to set it to "Progress" and press "tp" I get a warning and it pastes my current register. On the other hand it does not change the state of the parent headline, when I set a child into "Progress", so I am not able to fix inconsistent states.

I then actually took the time to see, how the feature behaves in Emacs. There you can change the state of the parent headline as long as it is not a state considered as "closed" (a state defined on the right hand side of the "|" in the configuration list).

To get this merged, we should mimic the behavior of Emacs org mode.

seflue · 2024-06-02T21:24:26Z

tests/plenary/object/todo_dependency_spec.lua

+
+local M = {}
+-- @param headline OrgApiHeadline
+-- local M.vis_head = function (headline, indent)


Please remove dead code.

seflue · 2024-06-03T07:12:09Z

lua/orgmode/org/mappings.lua

+function OrgMappings:_has_unfinished_children(headline)
+  for _, h in ipairs(headline:get_child_headlines()) do
+    local was_done = h:is_done()
+    if not was_done then


Do we need this local variable? It is not used later on, isn't it?

Suggested change

if not was_done then

if not h:is_done() then

return true

end

seflue · 2024-06-03T07:18:40Z

lua/orgmode/org/mappings.lua

+    if not was_done then
+      return true
+    end
+    if OrgMappings:_has_unfinished_children(h) then


I stumbled over this recursion and after some moments I recognized, that not every headline is a todo. I think this is worth a comment.

seflue · 2024-06-03T07:28:19Z

tests/plenary/object/todo_dependency_spec.lua

+  return false
+end
+
+describe('Todo mappings unfer force dependency', function()


seflue · 2024-06-03T07:34:52Z

tests/plenary/object/todo_dependency_spec.lua

+    }, vim.api.nvim_buf_get_lines(0, 2, 4, false))
+  end)
+
+  it('should change todo state of a headline backward (org_todo_prev)', function()


Duplicate test name? Can you reflect the difference to the former test in the name?

seflue · 2024-06-03T07:41:28Z

tests/plenary/object/todo_dependency_spec.lua

@@ -0,0 +1,329 @@
+local config = require('orgmode.config')


I appreciate, that you wrote tests. I saw that some of them are actually testing multiple things. I'm my experience this can make a regression harder to track, although it's much better than having no test. Would you mind to split the tests up a little bit?

PannenetsF · 2024-10-29T09:49:52Z

@PannenetsF I finally found the time to play around with your contribution. First I was not sure if I misunderstood how the feature is supposed to work, but what was immediately noticeable is that changing the TODO state of a parent headline is completely blocked. And it is actually blocked on pressing "t", so if I want to set it to "Progress" and press "tp" I get a warning and it pastes my current register. On the other hand it does not change the state of the parent headline, when I set a child into "Progress", so I am not able to fix inconsistent states.

I then actually took the time to see, how the feature behaves in Emacs. There you can change the state of the parent headline as long as it is not a state considered as "closed" (a state defined on the right hand side of the "|" in the configuration list).

To get this merged, we should mimic the behavior of Emacs org mode.

Hi Seflue, thanks for your review. I would read the original Emacs orgmode for better mimic behavior. I am kind of busy these weeks. Will try to fetch time to do that
:-)

ficd0 · 2025-01-28T06:58:29Z

Is there any update on this ? I'd love to see this feature. I could try updating the PR if @PannenetsF doesn't have the time.

PannenetsF · 2025-01-28T07:10:03Z

Sounds good to me:) I just developped the very simple demo in my local branch. But i have no time to check as I would be busy with my graduation thesis for months.  Best regards, Yunqian Fan

…

---Original--- From: "Daniel ***@***.***> Date: Tue, Jan 28, 2025 14:58 PM To: ***@***.***>; Cc: "Yunqian ***@***.******@***.***>; Subject: Re: [nvim-orgmode/orgmode] feat(core): supportorg-enforce-todo-dependencies (PR #741) Is there any update on this ? I'd love to see this feature. I could try updating the PR if @PannenetsF doesn't have the time. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

LoydAndrew · 2025-07-17T11:22:11Z

Hi, thanks for all the contribution. Could this be merged? Are there any blockers?

feat(core): support org-enforce-todo-dependencies

7413717

add warning for blocked tasks

PannenetsF force-pushed the dev-org-enforce-todo-dependencies branch from 08c4490 to 7413717 Compare June 3, 2024 05:25

seflue suggested changes Oct 19, 2024

View reviewed changes

kristijanhusak force-pushed the master branch from ae38aa8 to de701e8 Compare September 8, 2025 09:11

Uh oh!

Comments

Conversation

PannenetsF commented Jun 2, 2024

Uh oh!

seflue commented Jun 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PannenetsF commented Jun 3, 2024

Uh oh!

Dardanos-Aeolus commented Sep 30, 2024

Uh oh!

seflue commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seflue Jun 2, 2024

Choose a reason for hiding this comment

Uh oh!

seflue Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

seflue Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

seflue Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

seflue Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

seflue Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

seflue Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

PannenetsF commented Oct 29, 2024

Uh oh!

ficd0 commented Jan 28, 2025

Uh oh!

PannenetsF commented Jan 28, 2025 via email

Uh oh!

LoydAndrew commented Jul 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

seflue commented Jun 2, 2024 •

edited

Loading

seflue commented Oct 19, 2024 •

edited

Loading