Conversation
alex-courtis
requested changes
Feb 23, 2026
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Many thanks for your contribution.
The icon does indeed look like a dune, however it is for a different framework that we may one day add.
Proposal:
Use the ocaml icon, with a different colour. We have followed that pattern for python and other frameworks/languages.
Colour is up to you :)
Author
|
@alex-courtis done, but would be an issue akka and dune to have the same icon? They are from different stacks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding icon for
dunefiles. Dune is a build tool for Ocaml projects.Since there is no icon for dune in nerd fonts, I used
nf-dev-akkawhich is the Scala Akka icon, but it seems a lot like a dune to me 😂 not sure if this is a problem.Here's a SC on how it looked like in a OCaml project.