Skip to content

feat(typescript): type and interface as @parameter.* #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiyoon merged 1 commit into from
Jun 14, 2025
Merged

feat(typescript): type and interface as @parameter.* #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions queries/typescript/textobjects.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,65 @@
.
"}"
(#make-range! "class.inner" @_start @_end)))

; type, interface items as @parameter
; 1. parameter.inner
(property_signature) @parameter.inner

; 2. parameter.outer: Only one element, no comma
(object_type
.
(property_signature) @parameter.outer .)

(interface_body
.
(property_signature) @parameter.outer .)

; 3. parameter.outer: Comma/semicolon before or after
([
(object_type
"," @_start
.
(property_signature) @_end)
(interface_body
"," @_start
.
(property_signature) @_end)
]
(#make-range! "parameter.outer" @_start @_end))

([
(object_type
(property_signature) @_start
.
"," @_end)
(interface_body
(property_signature) @_start
.
"," @_end)
]
(#make-range! "parameter.outer" @_start @_end))

([
(object_type
";" @_start
.
(property_signature) @_end)
(interface_body
";" @_start
.
(property_signature) @_end)
]
(#make-range! "parameter.outer" @_start @_end))

([
(object_type
(property_signature) @_start
.
";" @_end)
(interface_body
(property_signature) @_start
.
";" @_end)
]
(#make-range! "parameter.outer" @_start @_end))
Comment on lines +56 to +102
Copy link

Copilot AI Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma/semicolon separator patterns for object_type and interface_body are duplicated. Consider refactoring or adding clarifying comments to explain the necessity for the similar blocks to improve maintainability.

Suggested change
([
(object_type
"," @_start
.
(property_signature) @_end)
(interface_body
"," @_start
.
(property_signature) @_end)
]
(#make-range! "parameter.outer" @_start @_end))
([
(object_type
(property_signature) @_start
.
"," @_end)
(interface_body
(property_signature) @_start
.
"," @_end)
]
(#make-range! "parameter.outer" @_start @_end))
([
(object_type
";" @_start
.
(property_signature) @_end)
(interface_body
";" @_start
.
(property_signature) @_end)
]
(#make-range! "parameter.outer" @_start @_end))
([
(object_type
(property_signature) @_start
.
";" @_end)
(interface_body
(property_signature) @_start
.
";" @_end)
]
(#make-range! "parameter.outer" @_start @_end))
; Define a reusable macro for handling separators (comma/semicolon) and property_signature
(defmacro separator_pattern (separator)
([
(object_type
separator @_start
.
(property_signature) @_end)
(interface_body
separator @_start
.
(property_signature) @_end)
]
(#make-range! "parameter.outer" @_start @_end)))
; Use the reusable macro for comma separator
(separator_pattern ",")
; Use the reusable macro for semicolon separator
(separator_pattern ";")

Copilot uses AI. Check for mistakes.
Loading