Extend ocaml textobjects

[neojski]

Ocaml function textobjects updates.

I actually tested those when I wrote the change in meain/evil-textobj-tree-sitter#134 but I was kindly asked to upstream here.

[kiyoon]

Thanks for contributing.

Can you describe what it fixes and what the previous function capture was doing?

[neojski]

Added some inline comments to make it easier for future devs to understand it as well.

[neojski]

I would also appreciate some guidance on how to test it directly in this repo. README explains how to install it but it looks like it mostly focuses on the official package and not the locally developed one.

[neojski]

I managed to test it locally:

1. I needed to install nvim-treesitter-parser from AUR
2. ran nvim --clean -u scripts/minimal_init.lua test.ml

[neojski]

So, I think this doesn't actually cover some cases, e.g.

List.map ~f:(fun x -> x * x)

It won't match fun x -> x * x for inner function. I'll add those soon

[kiyoon]

A good way to design a query is

1. open :InspectTree
2. press o to open query editor/viewer

[neojski]

That's really useful, would you mind if I add that to https://github.com/nvim-treesitter/nvim-treesitter-textobjects?tab=contributing-ov-file?

I pushed the changes to handle the "standalone" fun & function now, so I think it's ready.

[neojski]

I also added struct & module support, which worked great locally, but those seem to be rejected 😢

I could go with using class for module, perhaps, and block for struct but that would be a breaking change for block. But I don't think parenthesized_expression is useful given that vi( just works.

[neojski]

I just did.

[kiyoon]

That's really useful, would you mind if I add that to https://github.com/nvim-treesitter/nvim-treesitter-textobjects?tab=contributing-ov-file?

Sure, please change the CONTRIBUTING.md file here.

I opened #856

[kiyoon]

assignment.inner should also select lhs as a separate query

[Copilot]

Pull request overview

This PR extends OCaml textobject support by adding patterns for more function definition styles and introducing assignment textobjects. The changes aim to provide better navigation and text selection capabilities for OCaml code in tree-sitter-based editors.

Key changes:

• Added function textobject patterns for lambda expressions (fun and function syntax) in both standalone and parenthesized contexts
• Added assignment textobjects with left-hand side, right-hand side, inner, and outer captures
• Added module definition textobjects using the @class capture
• Refined existing function textobjects to only match actual functions (with parameters)
• Removed generic parenthesized expression block pattern in favor of built-in editor support

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
queries/ocaml/textobjects.scm	Extended textobject queries with new patterns for functions, assignments, modules, and blocks
BUILTIN_TEXTOBJECTS.md	Updated documentation to reflect newly supported assignment textobjects for OCaml

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[neojski]

All done, I think?