feat: make NylasClient and its methods open for mocking #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the NylasClient class and its methods open to enable mocking in tests. - Added open modifier to NylasClient class - Made all resource accessor methods (messages, calendars, etc.) open - Made HTTP execution methods open for comprehensive mocking support Fixes #257 Co-Authored-By: Aaron de Mello <aaron.d@nylas.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=========================================
Coverage 81.28% 81.28%
Complexity 316 316
=========================================
Files 35 35
Lines 967 967
Branches 88 88
=========================================
Hits 786 786
Misses 129 129
Partials 52 52 ☔ View full report in Codecov by Sentry. |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Added entry under Unreleased section for making NylasClient and its methods open to enable mocking in tests. Co-Authored-By: Aaron de Mello <aaron.d@nylas.com>
AaronDDM
approved these changes
Jan 18, 2025
Merged
AaronDDM
added a commit
that referenced
this pull request
Jan 24, 2025
# Changelog * Made `NylasClient` and its methods open to enable mocking in tests (#258). * Added pagination support for folders (#259). * Fixed issue where reminders were not being updated correctly when updating an event (#261). # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make NylasClient and its methods open for mocking
This PR makes the NylasClient class and its methods open to enable mocking in tests, addressing issue #257.
Changes
openmodifier to NylasClient classTesting
These changes are purely related to class and method modifiers to enable mocking. The changes do not affect runtime behavior and maintain all existing functionality. The modifications only impact compile-time characteristics to allow for better testing capabilities.
Notes
Fixes #257
Link to Devin run: https://app.devin.ai/sessions/f6b8eb21945e4b84a4b26f39136760cd