Update folders: pagination added #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Saw that after but this PR is related to #254 that have the exact same problem as me |
alanschnegg
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
AaronDDM
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
Collaborator
|
Thanks for the PR @alanschnegg - I just added the select field support and included a changelog line. |
AaronDDM
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
AaronDDM
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
AaronDDM
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=========================================
Coverage 81.28% 81.28%
Complexity 316 316
=========================================
Files 35 35
Lines 967 967
Branches 88 88
=========================================
Hits 786 786
Misses 129 129
Partials 52 52 ☔ View full report in Codecov by Sentry. |
AaronDDM
approved these changes
Jan 17, 2025
Merged
AaronDDM
added a commit
that referenced
this pull request
Jan 24, 2025
# Changelog * Made `NylasClient` and its methods open to enable mocking in tests (#258). * Added pagination support for folders (#259). * Fixed issue where reminders were not being updated correctly when updating an event (#261). # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses a client requirement where the current folder fetch limit of 50 elements is insufficient due to their large number of folders. The changes include:
This enhancement improves usability for clients with extensive folder structures, enabling them to efficiently access and manage their data.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.