Skip to content

Conversation

@johnjjung
Copy link

Summary

  • correct the query parameter name for event ordering in ListEventQueryParams

Testing

  • ./gradlew test (fails: No route to host)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (fd84619) to head (2a558c4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #275   +/-   ##
=========================================
  Coverage     80.57%   80.57%           
  Complexity      333      333           
=========================================
  Files            36       36           
  Lines          1014     1014           
  Branches         88       88           
=========================================
  Hits            817      817           
  Misses          138      138           
  Partials         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@playerzero-ai
Copy link

playerzero-ai bot commented May 20, 2025

Pull Request Summary

  • Clarification of Functionality: The description for the orderBy field in the ListEventQueryParams class has been updated to specify that only "start" is supported for ordering event results. This clarifies the current limitations of the ordering functionality for users.

  • Consistency in API Communication: The JSON field name for orderBy has been changed from "participants" to "order_by". This change enhances consistency and clarity in how the API communicates ordering parameters, aligning with common naming conventions.

View more in PlayerZero
updated: May 20 @ 02:25 PM UTC

@johnjjung johnjjung requested a review from AaronDDM May 20, 2025 14:27
@johnjjung johnjjung closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants